View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0026473 | mantisbt | ui | public | 2019-12-15 21:38 | 2020-03-15 15:23 |
Reporter | teodor | Assigned To | atrol | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 2.23.0 | ||||
Target Version | 2.24.0 | Fixed in Version | 2.24.0 | ||
Summary | 0026473: Incorrect CSS rules get applied if a word in custom field name matches an existing CSS class | ||||
Description | Custom fields can contain spaces, at times custom field names are passed within the | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Here is another screenshot that hopefully captures the issue entirely. |
|
Thanks @teodor for the detailed report. Implemented a simple fix for it https://github.com/mantisbt/mantisbt/pull/1598 |
|
Please take note of 1st bullet in Admin Guide, Custom Fields definition section http://mantisbt.org/docs/master/en-US/Admin_Guide/html-desktop/#admin.customize.customfields.definitions
I'm wondering if we should not enforce this in the code instead of leaving it as a free text and implement hacks. Or if we're going to use the replace by underscore trick, then it needs to be global and consistent (and we should probably other special chars as well). |
|
MantisBT: master 18437666 2019-12-15 21:41 Details Diff |
Correct CSS class names for custom fields Not all characters are allowed to be used in CSS class names. Replace any potentially unsupported character(s) by dashes `-`. Fixes 0026473 |
Affected Issues 0026473 |
|
mod - core/custom_field_api.php | Diff File | ||
mod - core/custom_function_api.php | Diff File |