View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0026596 | mantisbt | installation | public | 2020-01-15 08:48 | 2020-03-15 15:23 |
Reporter | obmsch | Assigned To | dregad | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 2.23.0 | ||||
Target Version | 2.23.1 | Fixed in Version | 2.23.1 | ||
Summary | 0026596: Wrong defaults for db (plugin) table prefix/suffix | ||||
Description | Starting with 2.23.0 the defaults are all 'mantis'. Before (<=2.22.2) they were 'mantis', 'plugin' and '_table'. | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
@dregad it would be good to have this targetted to 2.23.1 |
|
@dregad I noticed that, when I checked for db-schema changes installing with 'adodb-5.21' (current master). custom_field.possible_values That's expected after the recent changes to BLOB handling for some dbs. I don't use custom fields myself, |
|
@obmsch definitely unintended ! As @atrol pointed out, I was already aware of this problem and fixed it a few days ago. The patch is ready, but not merged in main repository as I was also working on a few other issues in the same area, and I have not finished testing. Thanks for opening the issue, I was planning to do it myself. |
|
Thanks for the heads up ! |
|
The regression was introduced by MantisBT master 86eb8dec The root cause is a change on the span tags storing the default values for the prefix/suffix, switching from name to id, and the id was of course not unique on the page since it was used for both the oci8 and other defaults. |
|
MantisBT: master 86eb8dec 2019-09-04 02:19 Details Diff |
Fix invalid HTML - remove stray </table> tag - 'name' is not a valid attribute for <span>, replace by 'id' - remove deprecated <table> attributes |
Affected Issues 0026596 |
|
mod - admin/install.php | Diff File | ||
mod - js/install.js | Diff File | ||
MantisBT: master 85a30e9a 2020-01-06 04:49 Details Diff |
Fix DB prefix/suffix init for new Mantis installs When installing a new MantisBt instance, the installer pre-fills the database prefix, plugin-prefix and suffix inputs. Due to a bug in the code, all 3 fields were set to the value of db_table_prefix ('mantis' by default), resulting in the installer creating tables like 'mantis_bug_mantis` or 'mantis_mantis_xxx_mantis' instead of 'mantis_bug_table' or 'mantis_plugin_xxx_table' unless the administrator noticed and fixed the values before launching the install. Adjust the code that initializes the inputs to use the correct values (db_table_plugin_prefix, db_table_suffix). Fixes 0026596 |
Affected Issues 0026596 |
|
mod - admin/install.php | Diff File | ||
MantisBT: master 2b98c4e4 2020-01-07 05:32 Details Diff |
Install: fix default prefix change by DB type The JavaScript that changes the default table prefix/suffix based on database type and populates the sample table name fields was broken because multiple DOM elements with the same id existed on the page (2 sets of hidden <span> for the default values, and the 3 <input>). Changing the markup for the <span> to set a class instead of an id, and ajusting the script fixed the problem. Fixes 0026596 |
Affected Issues 0026596 |
|
mod - admin/install.php | Diff File | ||
mod - js/install.js | Diff File |