View Issue Details

IDProjectCategoryView StatusLast Update
0027274mantisbtuipublic2023-12-03 12:31
Reporterdregad Assigned Todregad  
PrioritynormalSeveritytweakReproducibilityN/A
Status closedResolutionfixed 
Target Version2.26.0Fixed in Version2.26.0 
Summary0027274: Move Delete buttons into main form
Description

Before HTML 5 it was not possible to have multiple buttons sending form data to different target pages.

Consequently, we have several places in Mantis UI where there are buttons printed outside of the main form, resulting in a not-so-nice-looking UI (see screenshot for illustration).

With HTML 5 button and formaction attribute, this is now possible, so we should fix these glitches.

TagsNo tags attached.
Attached Files
image.png (20,542 bytes)   
image.png (20,542 bytes)   

Relationships

related to 0027808 closedatrol Questionable UI / button on "Edit Project Category" page 
related to 0033248 closeddregad APPLICATION ERROR 2800 Invalid form security token when trying to delete custom field 
child of 0030551 closeddregad Project Edit Page improvements 

Activities

Related Changesets

MantisBT: master f6234f0e

2020-09-10 12:47

dregad


Details Diff
Move Delete button to form footer: Project

Using the HTML5 button's `formaction` property we can get rid of the
separate form that caused the button to be displayed below the Edit box,
and put the Delete button in the main form's footer

This required the following additional changes
- using the same CSRF token `manage_proj_update` for deletion

Fixes 0027274
Affected Issues
0027274
mod - manage_proj_delete.php Diff File
mod - manage_proj_edit_page.php Diff File

MantisBT: master aaa671c2

2020-09-10 12:50

dregad


Details Diff
Move Delete button to form footer: Category

Using the HTML5 button's `formaction` property we can get rid of the
separate form that caused the button to be displayed below the Edit box,
and put the Delete button in the main form's footer

This required the following changes
- renaming the form parameter from `id` to `category_id`
- using the same CSRF token `manage_proj_cat_update` for deletion

Fixes 0027274
Affected Issues
0027274
mod - manage_proj_cat_add.php Diff File
mod - manage_proj_cat_delete.php Diff File
mod - manage_proj_cat_edit_page.php Diff File
mod - manage_proj_edit_page.php Diff File
mod - manage_proj_page.php Diff File

MantisBT: master 6db5ae6a

2020-09-10 13:27

dregad


Details Diff
Move Delete button to form footer: Version

Using the HTML5 button's `formaction` property we can get rid of the
separate form that caused the button to be displayed below the Edit box,
and put the Delete button in the main form's footer.

Fixes 0027274
Affected Issues
0027274
mod - manage_proj_ver_delete.php Diff File
mod - manage_proj_ver_edit_page.php Diff File

MantisBT: master 8116b5e3

2022-06-02 09:14

dregad


Details Diff
Move Delete Custom Field button to form footer

Using the HTML5 button's `formaction` property we can get rid of the
separate form that caused the button to be displayed below the Edit box,
and put the Delete button in the main form's footer

Fixes 0027274
Affected Issues
0027274, 0033248
mod - manage_custom_field_edit_page.php Diff File

MantisBT: master-2.26 fe404e16

2023-12-01 19:03

dregad


Details Diff
Fix error 2800 when deleting custom field

This error is a regression introduced by fix for issue 0027274.

Changing security token name in manage_custom_field_delete.php from
manage_custom_field_delete to manage_custom_field_update resolves the
problem.

It makes more sense to reuse the existing token rather than generate a
new, specific one in manage_custom_field_edit_page.php since we're using
the same form data for update and delete operations.

Fixes 0033248
Affected Issues
0027274, 0033248
mod - manage_custom_field_delete.php Diff File