View Issue Details

WikiRelated ChangesetsJump to Notes
IDProjectCategoryView StatusDate SubmittedLast Update
0030494mantisbtjavascriptpublic2022-06-07 09:142022-06-12 17:19
Reporterdregad Assigned Todregad  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Target Version2.26.0Fixed in Version2.26.0 
Summary0030494: list.js navigation buttons scrolling to top of page
Description

The recently updated list.js library version 2.3.1 (see 0030490) has a bug causing the navigation buttons to scroll the page to the top when clicked.

This has been reported upstream with a patch https://github.com/javve/list.js/pull/750

TagsNo tags attached.

Relationships

child of 0030490 resolveddregad list.js library causing CSP violation in manage_proj_edit_page.php 
child of 0030551 resolveddregad Project Edit Page improvements 

Activities

dregad

dregad

2022-06-07 09:24

developer   ~0066699

This bug makes navigation between multiple pages of managed users quite painful, requiring the user to scroll down to the Manage Accounts section after each click on a page button.

Considering the annoyance factor for this issue, and the fact that list.js has not been updated for over a year with the author not responding to issues and pull requests, I'll patch the bundled libraries; instances relying on CDN should either switch to locally-served scripts, or live with it...
dregad

dregad

2022-06-07 10:18

developer   ~0066701

PR https://github.com/mantisbt/mantisbt/pull/1821

Related Changesets

MantisBT: master 7c0e2b85

2022-06-07 09:16

dregad


Details Diff		 Fix scrolling regression in list.js 2.3.1

This is the patch submitted upstream [[1]].

Fixes 0030494

[1]: https://github.com/javve/list.js/pull/750		 Affected Issues
0030494
mod - js/list-2.3.1.js Diff File
mod - js/list-2.3.1.min.js Diff File
mod - library/README.md Diff File

MantisBT: master 582d5d50

2022-06-12 16:57

dregad


Details Diff		 Fix list.js scrolling regression patch

The list.js patch for the scrolling regression (issue 0030494, commit
7c0e2b8590c1e2c6ab17a566e14839584009a064) introduced another regression,
because preventing the default click event's execution not only applied
to the pagination buttons, but also to the checkboxes and the Apply
button as well, basically making the whole Manage Accounts section
unusable.

To fix the problem, we now only execute preventDefault() when the
pagination buttons are clicked.

Fixes 0030494		 Affected Issues
0030494
mod - js/list-2.3.1.js Diff File
mod - js/list-2.3.1.min.js Diff File